Docs at http://drupal.org/node/1066342 / http://git-dev.drupal.org/node/1066342 are not in sync with "Git instructions" tab under projects.

Should tags be created as "Git instructions" tab say:

git tag 7.x-1.0

or how the docs http://drupal.org/node/1066342 say, using annotated tags?

git tag -a 7.x-1.0 -m 'release 1.0'

Comments

eliza411’s picture

eliza411 commented
Status: Active » Fixed

Reconciling this in favor of Git's default, non-annotated, in part because its the default, also because we don't have any best practice recommendations for the use of them, and ultimately, because I know some corners of our systems aren't very smart about them.

eliza411’s picture

eliza411 commented

P.S. Thanks for pointing it out!

dww’s picture

dww
we/he/they
commented

Related:
#1073690: Use real tags instead of lightweight ones
#1023638: Use tag annotation for the default release node body.

I'm fine with lightweight tags for now, but it'd be good to consider documenting annotated tags in the future when we have better support for them...

Cheers,
-Derek

marvil07’s picture

marvil07 commented

because I know some corners of our systems aren't very smart about them.

I can confirm annotated tags works fine in the workflow, actually I have just released vote_up_down 6.x-2.4 with an annotated tag.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

langworthy’s picture

langworthy commented

As mentioned in #1073690: Use real tags instead of lightweight ones tags should be annotated. Git does the wrong thing by default.

sdboyer’s picture

sdboyer commented

@marvil07 - yeah, we can parse them, but we don't actually record any tag metadata. And I'm not actually certain if we properly dereference the tag into its underlying commit or not - do we?