Problem/Motivation

Split out from #3537036: Written confirmation. Use cases:

  • B . Lastly, sites may wish to send confirmations in some or all cases even where they don't strictly need to, simply to minimise audit-related risk.
  • C. Sites may in some circumstances wish to resend confirmations, for example if they discover mistakes in the text of past confirmations, in cases of data entry error, or updated donor contact information.

Proposed resolution

Create a declaration action that sends a confirmation mail (analogous to Commerce "resend confirmation mail").

We will allow the staff to trigger an extra confirmation if validity == "valid if confirmed" || !hasClaimed(). This avoids shooting ourselves in the foot when we have a perfectly valid declaration that already has claims to HMRC.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

adamps created an issue. See original summary.

adamps’s picture

adamps commented

Another option: create a declaration action that sends a confirmation mail. This separates it from declaration form, so that we aren't force to make a null declaration revision in order to send the mail. It's analogous to Commerce "resend confirmation mail".

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented

Another nuance here is that if an admin edits a declaration after a confirmation has been sent, they should be allowed & helped to resend the confirmation.

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented

Now that we're not providing a mechanism for retrospective just-in-case validation in #3537036: Written confirmation, I don't see this issue as a priority.

adamps’s picture

adamps commented
Issue summary: View changes