I feel that requiring "dev-master" of the geshi library might end up in some compatibility breaking.
http://cgit.drupalcode.org/geshifilter/tree/composer.json?h=8.x-1.x

I think is more reasonable to require something like "^1.0" so you still get updates for 1.0.9, 1.0.10, etc

CommentFileSizeAuthor
#2 2906413-require-geshi-2.patch283 bytesrodrigoaguilera

Comments

rodrigoaguilera created an issue. See original summary.

rodrigoaguilera’s picture

Status: Active » Needs review
StatusFileSize
new283 bytes

A simple patch

Status: Needs review » Needs work

The last submitted patch, 2: 2906413-require-geshi-2.patch, failed testing. View results

olarin’s picture

This definitely needs to be addressed. This blocked me from installing geshifilter via composer, as my project required at least stability "alpha" which dev-master does not satisfy. Furthermore, the project page for this module explicitly warns *against* using the latest dev version of the geshi library and instructs using the stable 1.0.x branch.

For now, my workaround for using composer was to manually add geshi library to my composer.json like this:

"geshi/geshi": "1.0.9.0 as master",

In other words, "grab this particular version but trick anyone who depends on this module into thinking we pulled the master development branch".

olarin’s picture

(Note about my workaround: unfortunately, you may need to remove the entire /vendor/geshi directory each time you run composer with my workaround in place to avoid cryptic errors like "Problem 1 - Removal request for geshi/geshi == 9999999-dev".)

yukare’s picture

In the past, geshi/geshi recommended the use of dev-master(before the 1.0.9 release) but now they too recommend the use of 1.0.9. I Just have one question before i commit this path, how it will affect existing users that have dev-master? Composer will change without errors from dev-master to 1.0.9 ?

rodrigoaguilera’s picture

Status: Needs work » Needs review

Exactly, composer will downgrade the library for those that are on dev-master. As long as this module is not using features that are only on the master branch and not on the 1.0.9 release I think is safe to do it.

yukare’s picture

Status: Needs review » Fixed

This is commited, thanks.
But in my tests it gave me an error in composer, it did not change from dev to 1.0.9. It is possible to fix it by removing the geshifilter and requiring it again, i put a note about this in project page.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.