Problem/Motivation

The use of CartoDB map tiles now requires an API key, which is not supported by this module (or its geolocation_leaflet submodule).

Steps to reproduce

1. Use a leaflet map with CartoDB tiles such as CartoDB Voyager.
2. See watermark on the retrieved tiles stating "API Key Required https://carto.com/basemaps/apikey/".

This is also visible on the public Leaflet providers demo here: https://leaflet-extras.github.io/leaflet-providers/preview/#filter=Carto...

Proposed resolution

Add support to the field formatter where the tileset is chosen and configured for setting the API key for CartoDB tilesets similarly to HERE/Thunderforest/MapTiles API.

Remaining tasks

As this module depends on leaflet-extras/leaflet-providers to resolve the URL for the map tiles, that library will also need to be updated to accept API keys for CartoDB tilesets. I've created this issue for that: https://github.com/leaflet-extras/leaflet-providers/issues/703

I don't believe there are any other changes needed to this specific module, though I would appreciate a review by someone more experienced with this module.

Issue fork geolocation-3619581

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

seanpb created an issue. See original summary.

seanpb’s picture

seanpb commented

I think the extent of the changes required to the module are here on my feature branch: https://git.drupalcode.org/issue/geolocation-3619581/-/tree/3619581-cart...

christianadamski changed the visibility of the branch 3619581-cartodb-tiles-now to hidden.

christianadamski changed the visibility of the branch 3619581-cartodb-tiles-now to active.

christianadamski’s picture

christianadamski commented
Version: 8.x-3.x-dev » 4.x-dev

christianadamski changed the visibility of the branch 3619581-cartodb-tiles-now to hidden.

christianadamski opened merge request !172

christianadamski’s picture

christianadamski commented

Here's the v3 MR based on your code: https://git.drupalcode.org/project/geolocation/-/merge_requests/172

  • 06612ba0 committed on 8.x-3.x 
    #3619581 add support for api keys for CartoDB tilesets
christianadamski’s picture

christianadamski commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

seanpb’s picture

seanpb commented

Thanks Christian!