Problem/Motivation

After upgrading to Geolocation 4.0.0, editing or saving a View using the Geolocation common map style can produce a config schema warning for the new "Map Control - View Fullscreen" feature.

Example warning:

views.view.VIEW_ID:display.DISPLAY_ID.display_options.style.options.map_provider_settings.map_features.control_view_fullscreen.settings.position missing schema

The feature stores a position setting, but config/schema/geolocation.map_features.schema.yml does not define schema for plugin.plugin_configuration.geolocation.map_feature.control_view_fullscreen.

Steps to reproduce

  1. Install or upgrade to Geolocation 4.0.0.
  2. Create or edit a Views display using the Geolocation common map style.
  3. Enable or save configuration that includes "Map Control - View Fullscreen".
  4. Save the View.
  5. Check the View edit page or run a config schema check.

Expected behavior: The View config validates without schema warnings.

Actual behavior: Drupal reports a missing schema warning for control_view_fullscreen.settings.position.

Proposed resolution

Add schema for plugin.plugin_configuration.geolocation.map_feature.control_view_fullscreen in config/schema/geolocation.map_features.schema.yml, matching other map controls that store a position setting.

plugin.plugin_configuration.geolocation.map_feature.control_view_fullscreen:
  type: geolocation.map_feature_settings
  label: 'Map Control - View Fullscreen'
  mapping:
    settings:
      type: mapping
      label: 'Settings'
      mapping:
        position:
          type: string
          label: 'Position'

Remaining tasks

  • Add the schema entry.
  • Add or update test coverage if appropriate.
  • Confirm the schema warning no longer appears.

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

nick hope created an issue. See original summary.

christianadamski’s picture

Status: Active » Fixed

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.