Problem/Motivation

`GeofieldDms` and `GeofieldElementBase` classes in the Geofield module extend the deprecated `Drupal\Core\Render\Element\FormElement` class, which causes deprecation warnings when running Upgrade Status or preparing for Drupal 11:
`Class Drupal\geofield\Element\GeofieldDms extends deprecated class Drupal\Core\Render\Element\FormElement. Deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. use Drupal\Core\Render\Element\FormElementBase instead.`

Steps to reproduce

  1. Install Geofield module
  2. Run Upgrade Status module scan
  3. Review deprecation warnings for Geofield

Proposed resolution

Replace FormElement with FormElementBase in both element classes:

  • The use statement
  • The class declaration
  • The annotation

Remaining tasks

I am attaching a patch that can provide a workaround until this is fixed.

CommentFileSizeAuthor
#2 geofield-formElement-deprecated_#2.patch1.22 KBitamair
geofield-formElement-deprecated.patch1.13 KBtitacvetkovic

Comments

titacvetkovic created an issue. See original summary.

itamair’s picture

itamair commented
Status: Active » Fixed
StatusFileSize
new geofield-formElement-deprecated_#2.patch1.22 KB

Thanks @titacvetkovic, nice catch.
But the patch you provided doesn't apply, because from the /tmp root.

This new provided patch applies correctly.

Committing that into the 8.x-1.x dev branch.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • itamair committed e3066869 on 8.x-1.x 
    feat: #3566397 `GeofieldDms` and `GeofieldElementBase` classes in the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.