Would be great to add a checkbox to toggle the breadcrumb on and off in the theme settings page. I tried just deleting it in the sub-theme page.tpl.php, but its absence broke some pages.

Comments

Jeff Burnz’s picture

I am very reluctant to add any theme settings at all (it complicates things). I'll think about it a bit more.

If its breaking your theme then you need to look at your own CSS mods, no breadcrumb showing shouldn't make a lot of difference since its a full width DIV, not floated or anything.

A link to your test site would be good.

fred0’s picture

Duh. Good point. Easy fix, add display none:

#breadcrumb {
  margin: 0;
	display: none;
}
Jeff Burnz’s picture

Status: Active » Closed (fixed)

Good o.

belong@mywebworkshop.com’s picture

Status: Closed (fixed) » Active

I see you don't really want to do it, and I can certainly make it invisible using css, but this adds clutter and bandwidth in the file.
I tick box on the theme settings page would be tidier from an end code point of view.
Cheers
Miriam

Jeff Burnz’s picture

Status: Active » Closed (won't fix)

Well in fact its the opposite...

You can do something as simple as this in template.php to toggle the breadcrumb off:

function mytheme_preprocess_page(&$vars, $hook) {
  unset($vars['breadcrumb']);
}

Essentially 2 lines of code. You can go one step further and simply remove the breadcrumb code from page.tpl.php (you should ideally do both).

I'm changing this to wont fix, the idea of Genesis is that its a simple theme and I want to keep it that way, adding theme settings for base theme / sub themes is rather complicated affair (I also built Adaptivetheme which has more than 80 such settings, so I know all about this...).

I say your comments are the opposite because the amount of code required to add a toggle setting is a great deal more than this.

belong@mywebworkshop.com’s picture

Thanks Jeff - I was thinking of the code being delivered in the user's browser.

I deleted from page.tpl.php.
We have a whole bunch of tick boxes for a theme - primary menu, logo, author displays, etc etc, so as a newbie that feels like a very fine (and simple) place to turn things on and off when it is simple on/off choice. I'll get used to dabbling in page.tpl.php eventually I guess.

Cheers
Miraim