Closed (fixed)
Project:
Freetobook Widget
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
11 Jul 2011 at 11:32 UTC
Updated:
17 Oct 2011 at 08:41 UTC
This module could use small fixes to bring it inline with the Drupal coding standards, particularly:
A few other recommendations:
$imagePath = drupal_get_path('module', 'freetobook_widget'); Good work!
Comments
Comment #1
freetobook commentedThanks for the feedback,
I have reformatted the code, and checked it with the coder module so it should
meet the coding standards now.
I have refactored the output code to use more of the theme_ hooks so
hopefully it is now more consistent with best practices.
I have fixed the 'mis-spelling' in the info file.
Comment #2
damienmckennaThere are still improvements necessary in the .module file - lots of issues with spacing, many missing comments (every function should have a leading comment), and the new JS file also needs to be formatted correctly. You're almost there :)
Comment #3
freetobook commentedHave added additional comments and edited the spacing.
Comment #4
freetobook commented