Problem/Motivation
I use the form steps in the frontend for a while now. But after update to 1.5, the form is rendered with the backend theme instead of the frontend theme.
Steps to reproduce
- Install module
- Configure a form step for a content type and use an url that is not tied to the backend. For example /dashboard/advertise/car/general
Proposed resolution
Allow to use the frontend theme.
Remaining tasks
Create patch
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | interdiff_11_12.txt | 11.38 KB | nicoloye |
| #12 | forms_steps-not_working_with_frontend_theme-3211043-12.patch | 13.22 KB | nicoloye |
| #11 | interdiff_6_11.txt | 2.64 KB | nicoloye |
| #11 | forms_steps-not_working_with_frontend_theme-3211043-11.patch | 3.92 KB | nicoloye |
| #9 | forms_steps-not_working_with_frontend_theme-3211043-6.patch | 3.49 KB | m.anoune |
Comments
Comment #2
tim-dielsI think the solution in #3104208: Using the admin theme for editing via 'Steps' is a bit to fast. I would suggest having a setting on the form steps workflow to set this setting per workflow.
Comment #3
nicoloye commentedThanks Tim, you're right, it was a bit too radical as a solution.
I'm raising the priority of this point to propose a solution asap.
Thanks for your request !
Comment #4
nicoloye commentedComment #5
himisha commentedAdded a patch that adds ability to toggle the admin theme for Forms Steps.
Comment #6
himisha commentedComment #8
tim-dielsI'm not sure why the test is failing and the codesniffer is not related to this patch.
I can confirm the patch is working. So setting RTBC.
Comment #9
m.anoune commentedThe patch is OK for me but not applying correctly, maybe after this rewrite it w'll work fine
Comment #11
nicoloye commentedHere is a small fix to avoid the manual cache clear for the setting to be taken into account.
The patch is strangely not properly detected by my interdiff tool but I'm posting it as is anyway.
I'm working on this to allow more options.
Comment #12
nicoloye commentedI changed the feature a bit to allow overriding the theme on a step level.
Please review, thanks !
Comment #13
nicoloye commentedComment #15
nicoloye commentedComment #16
tim-dielsBrilliant addition there @nicoloye! I've tested this on our website and works perfectly!
Not sure why the tests are failing tho.