Problem/Motivation

I use the form steps in the frontend for a while now. But after update to 1.5, the form is rendered with the backend theme instead of the frontend theme.

Steps to reproduce

  1. Install module
  2. Configure a form step for a content type and use an url that is not tied to the backend. For example /dashboard/advertise/car/general

Proposed resolution

Allow to use the frontend theme.

Remaining tasks

Create patch

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

tim-diels created an issue. See original summary.

tim-diels’s picture

I think the solution in #3104208: Using the admin theme for editing via 'Steps' is a bit to fast. I would suggest having a setting on the form steps workflow to set this setting per workflow.

nicoloye’s picture

Thanks Tim, you're right, it was a bit too radical as a solution.

I'm raising the priority of this point to propose a solution asap.

Thanks for your request !

nicoloye’s picture

Priority: Normal » Major
himisha’s picture

Added a patch that adds ability to toggle the admin theme for Forms Steps.

himisha’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: forms_steps-not_working_with_frontend_theme-3211043-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tim-diels’s picture

Status: Needs work » Reviewed & tested by the community

I'm not sure why the test is failing and the codesniffer is not related to this patch.
I can confirm the patch is working. So setting RTBC.

m.anoune’s picture

StatusFileSize
new3.49 KB

The patch is OK for me but not applying correctly, maybe after this rewrite it w'll work fine

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: forms_steps-not_working_with_frontend_theme-3211043-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

nicoloye’s picture

Here is a small fix to avoid the manual cache clear for the setting to be taken into account.
The patch is strangely not properly detected by my interdiff tool but I'm posting it as is anyway.

I'm working on this to allow more options.

nicoloye’s picture

I changed the feature a bit to allow overriding the theme on a step level.
Please review, thanks !

nicoloye’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: forms_steps-not_working_with_frontend_theme-3211043-12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

nicoloye’s picture

Issue tags: +Europe2021
tim-diels’s picture

Status: Needs work » Reviewed & tested by the community

Brilliant addition there @nicoloye! I've tested this on our website and works perfectly!
Not sure why the tests are failing tho.