Closed (fixed)
Project:
Form Save
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Apr 2011 at 06:02 UTC
Updated:
15 May 2011 at 09:34 UTC
Jump to comment: Most recent file
Comments
Comment #1
johnvI just add my second comment in this same issue:
1. I think the configuration page is an unnecessary step in the installation process: your module is fairly simple; it has only 1 thing to do, so why bother going to a config page to activate after installation? A configuration page might be a good idea if you plan to have more options in the future, so you might consider setting the default value already to YES directly with installing. Site Admin then can Deactivate upon request without going to the modules page, which may be Developers's domain.
2. When you add the following line in the info file, the config page gets listed on the modules page:
configure = admin/config/content/form_save
3. When you add a README.txt file in your module, this also gets listed on the modules automatically when Advanced help is installed. If you do not want to maintain your info on 2 places (because it is already in the project page), it can contain a link to the drupal.org project page.
With points 2 and 3 in place, the modules page is my 'cockpit' for this module!
Comment #2
johnvAnd yes, the module works perfactly fine on IE8 and Chrome. Thanks!
Comment #3
timhilliard commentedHi John, thanks for testing the module. This is just the criticism I was looking for. I agree with all your comments and I will certainly be changing the module to 'Form save' and adding a README.txt. However the config page was there as when I was developing I thought I would need to have a config page but never ended up needing it so I'm going to remove it and make it so the module just works if it is enabled rather than the checkbox to enable it. I will try and roll these out today and may well release the first alpha very soon.
Cheers,
Tim
Comment #4
timhilliard commentedHi John,
I've made your recommended changes and now released them into the 7.x-1.0-alpha1 version.
Cheers,
Tim
Comment #5
johnvNice! I tried to download the package, but get the following result: "The requested URL /files/projects/form_save-7.x-1.0-alpha1.tar.gz was not found on this server."
Should I wait a night?
Comment #6
timhilliard commentedHi John,
It just worked for me. It looks like for some reason your browser hasn't expanded the URL to include the host. Try putting the full URL of http://ftp.drupal.org/files/projects/form_save-7.x-1.0-alpha1.tar.gz in your browser.
Cheers,
Tim
Comment #7
TimelessDomain commentedtried the full url from #6, but still not working
Comment #8
timhilliard commentedOk that's really weird and would be a d.o. problem. I've attached the module for you in this post so hopefully you can get it from here until the other link works for you.
Comment #9
johnvWhen I use http://ftp.drupal.org/files/projects , I land on a USA Oregon university mirror site. Perhaps we need to give it some time to spread the file over all CDN sites (if there are any..)
Comment #10
johnvFirst findings:
- your module is still called 'From Save' on the modules page;
- since you have removed the Configure page, you can remove the permissions, too.
- Do I need to flush caches to get is working? I will try to disable/enable to find this out.
Comment #11
timhilliard commentedHi John,
I've made the recommended changes you mentioned to dev. I also found a bug with my jquery code for key detection that I fixed. Is there anything else you have noticed that might need fixing. If not I will release alpha2.
Cheers,
Tim
Comment #12
johnvOK, Everything seems to work fine! But before setting a RTBC, some more nitpicking:
info-file:
+name = Form save
-name = Form Save // core modules do not use capitals either; if you change, then on project page, too
description = Allows users to save their forms using Ctrl+S or Cmd+S.
-package = Other // other si the default package, so you don't need to mention it here
module-file:
- function form_save_help() : seems like a copy&paste residue. Can be removed (?); the path 'admin/config/front' does not exist.
- function form_save_find_default_button(): I don't think this is supposed to be a public function? I believe common practice is to add prefix '_' and change the name then to _form_save_find_default_button($form, $buttons)
- some typo's below (but I don't know css, don't know if they are, and don't know if/when software is broken);
Comment #13
timhilliard commentedHi John, all worthy changes that I've now made and committed to dev.
You were right about the typo for default_button and the second place where the class was added was actually an error and should have been added as a blank array position like the first one.
If there is nothing else you can see I will release this.
Cheers,
Tim
Comment #14
johnvHi Tim, didn't the typo's break things? I suppose you have testcases with and without default buttons, and tested yourself, too. I only test some forms, not knowing if a default button is enabled or not. I can test again next friday.
Groeten, John
Comment #15
timhilliard commentedHi John, thanks for testing things it's been a great help! I might have to put a mention in the module page as you've been so active with this :)
Yeah I have been testing however I think the reason it was still working before is that you can use either a string or an array as the class variable (ill need to check this but I think thats the case). Since the form elements didn't have any classes applied it probably worked fine, however if more classes were trying to be applied it may have failed. The only other reason I can think of that it worked without me noticing is that the submit button was the only button or first button so it was applying the class from the other route although this seems unlikely.
I will try and put it through it's paces a bit more during the week as well.
Cheers,
Tim
Comment #16
johnvWell, looks goods, works fine! ready for the world!
Comment #17
johnvversion 1 is released.
Timothy, thanx for the credits on the project page.
Comment #18
timhilliard commentedclosing