function footnotes_init() {
  drupal_add_css(drupal_get_path('module', 'footnotes') . '/footnotes.css', array('group' => CSS_DEFAULT, 'every_page' => TRUE));
}

This is a very bad practice, so I think that will be correct to attach css in footnote.info file according to https://www.drupal.org/node/542202#stylesheets

CommentFileSizeAuthor
#2 moved_css_to_info-2860134-2.patch1.02 KBid.aleks

Comments

id.aleks created an issue. See original summary.

id.aleks’s picture

id.aleks commented
StatusFileSize
new moved_css_to_info-2860134-2.patch1.02 KB
id.aleks’s picture

id.aleks commented
pifagor’s picture

pifagor commented
Assigned: id.aleks » Unassigned
Priority: Normal » Major
Status: Active » Needs review
hingo’s picture

hingo commented

Hi id.aleks and pifagor

Thanks for this update.

I'm the original creator of Footnotes module. I no longer maintain it (nor do any other PHP or Drupal work) but I still get these emails. Over the years I've promoted many drupal devs to admin status for this module, but I'm afraid none of them might be active any longer. If nobody shows up soon, is it ok for you that I give you admin rights and you can then commit your patch?

pifagor, is it your intent to also review the patch, or were you merely curating the metadata?

id.aleks’s picture

id.aleks commented

Hello hingo. I would appreciate if you could give me admin right for your module. I have some idea in which way we must develop your module.

hingo’s picture

hingo commented

Ok, cool.

While I see that this is a very simple patch, could you find someone (else than me) to review and approve it. If yes, I'll check the boxes so you can start committing it. (...and other pending issues, as you have time)

pifagor’s picture

pifagor commented

I can check

pifagor’s picture

pifagor commented
Status: Needs review » Reviewed & tested by the community

Patch tested, it works

hingo’s picture

hingo commented

Cool. I've made both of you maintainers of Footnotes now. Please take good care of it!

Note that some days ago I also gave maintainer rights to @jzavrl. I expect him to make a commit from another ticket as well.

pifagor’s picture

pifagor commented

very grateful

yukare’s picture

yukare commented
Status: Reviewed & tested by the community » Fixed

Commited to git, thanks!

  • id.aleks authored 17f97ad on 7.x-2.x 
    Issue #2860134 by id.aleks: Move css attaching from hook_init

  • id.aleks authored 17f97ad on 7.x-3.x 
    Issue #2860134 by id.aleks: Move css attaching from hook_init

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.