Code review

Hi! I did a quick code and repository review, please consider these things:

• It appears you are working in a Master-branch, which is not used in Drupal-repositories, see this http://drupal.org/node/1127732
• README.txt is missing, see the guidelines for in-project documentation.
• Remove "version" from the info file, it will be added by drupal.org packaging automatically.
• Zend-framework dependency seems odd and most likely will drive many users away. Drupal 7 has a working autoloader(which you, btw, already trigger by placing the Fonecta.php file in the files array in the .info file), i suggest you use that one instead
• Fonecta.php looks like a third party library. If it is, license information is required to ensure it can be infact distributed in Drupal repository. If it is not third party, it needs to follow the same coding and commenting standards as the rest of the code.
• You have some coding standard issues, please check the module with the Coder- and the Drupal Code Sniffer modules and read this carefully. Some examples include:
  • Intends should always be 2 spaces, you now have mixed 3 spaces, 4 spaces, tabs, etc.
  • You have used t() function in install and menu hooks. Unfortunately t() is not always available during module installation which would then cause a fatal error. It is preferred to st() in those places, or even better, detect the correct localization function with $t = get_t().
  • The "?>" PHP delimiter at the end of files is discouraged, see http://drupal.org/node/318#phptags
  • Remove trailing white spaces
  • No line should exceed 80 characters. With long arrays, put each item on it's own line.
  • Pay attention to space delimiters. For example if (...) is correct but if(...) is not. Also $this = $that is correct, but $this=$that is not.

Majority of these will be detected(and even corrected) with the automated tools, you should really use them.

Anyway, thanks for the contribution, please answer this thread after you have dealt with these issues and i'll give it a second review round!