minor css issue

CommentFileSizeAuthor
#13 flux-contextual_links-1885682-13.patch2.1 KBdiscipolo
#3 finaloutput.jpg251.65 KBdiscipolo

Comments

discipolo’s picture

discipolo commented
Version: 7.x-1.x-dev » 7.x-1.0-alpha1

or is this fixed already in dev?

zirafa’s picture

zirafa commented
Status: Active » Needs work

Please provide a screenshot with more details about this problem so I can debug.

discipolo’s picture

discipolo commented
StatusFileSize
new finaloutput.jpg251.65 KB

Here is a Screenshot.

zirafa’s picture

zirafa commented

Hm, looks like maybe a padding issue. Does this error occur with certain contextual links or all contextual links (panels, views, blocks) etc)? It could be that the Pushtape admin links at the top don't have enough space to support contextual links for "configure block".

discipolo’s picture

discipolo commented
Status: Needs review » Needs work

contextual links in the menu will be fixed if we change every occurrence of

#block-menu-menu-pushtape ul to #block-menu-menu-pushtape ul.menu" and #block-menu-menu-pushtape a to #block-menu-menu-pushtape .menu in the css files, to make sure we are not styling the contextual links. you get the point.

the contextual links for views also act strangely. caused by style.css line 229 making #main display inline. removing inline makes the contextual links appear in the right place.

discipolo’s picture

discipolo commented
Status: Needs work » Needs review

if you need a patch feel free to assign as task to me.

zirafa’s picture

zirafa commented

Hm, shouldn't have to change the class name itself - it seems more likely a CSS bug.

zirafa’s picture

zirafa commented

the ccontextual links for views also act strangely. caused by style.css line 229 making #main display inline. removing inline makes the contextual links appear in the right place.

Have a patch for this? It could also lead to fixing the original issue too.

discipolo’s picture

discipolo commented

both things need to be fixed. the second issue is the position of the contextual links "launcher", the other issue is the contextual links themselves.

will make a patch for both if you change status to task and assign to me.

zirafa’s picture

zirafa commented

IMO it is a bug, not a task, see: http://drupal.org/node/73179. Since we are just dealing with Drupal markup, I still believe the issue should/can be fixed via CSS.

You can assign to yourself if you have a patch to submit, thanks.

discipolo’s picture

discipolo commented

The task at Hand is writing the patch since the issue is identified. I already specified the required css changes that will resolve the bug. Changing the class selector in the css file will make sure we are not theming contextual links along with the other menus by accident. I am not proposing anything other than css changes .

zirafa’s picture

zirafa commented
Status: Needs work » Needs review

Ok, I misunderstood your comment in #5. Thought you were suggesting markup changes, but understand the issue now. I'll try and find some time to review the fix in #5.

In the future, submitting a patch will make it easier to review proposed changes & avoid confusion.

Please read the post I linked to, which helps explain task vs bug report. It's not a hard and fast rule, but generally there is no need to switch the Category of the issue midway through - the Status is usually used for that.

From Tips for making a good issue report:

  • Bug Reports are for situations where the software does not work as was intended by the programmer.
  • Tasks are for something that just needs to get done, where the parameters are well understood. Whitespace repairs, adding translation function support, fixing spelling errors etc are usually just 'tasks'.
discipolo’s picture

discipolo commented
Version: 7.x-1.0-alpha1 » 7.x-1.x-dev
Component: User interface » Code
StatusFileSize
new flux-contextual_links-1885682-13.patch2.1 KB

here is the promised patch with the changes from #5

zirafa’s picture

zirafa commented
Status: Needs review » Fixed

Committed to 7.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.