Problem/Motivation

The module is unable to be installed on PHP7.3.
Type declarations for class properties are supported since PHP7.4.
Type Declarations (PHP.net)

Steps to reproduce

Try to install the module on a PHP7.3 environment.

Proposed resolution

  • Remove type declaration in FlexmailAccount class properties.

Remaining tasks

Create a patch (working on this)

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#3 support-for-PHP73-3247712-3.patch1.22 KBFonteijne

Comments

Fonteijne created an issue. See original summary.

Fonteijne’s picture

Fonteijne commented
Title: Support for PH7.3 » Support for PHP7.3
Fonteijne’s picture

Fonteijne commented
StatusFileSize
new support-for-PHP73-3247712-3.patch1.22 KB

Created a patch to remove the Type Declarations in FlexmailAccount.

Fonteijne’s picture

Fonteijne commented
Status: Active » Needs review
Fonteijne’s picture

Fonteijne commented
Assigned: Fonteijne » Unassigned

daften’s picture

daften commented
Status: Needs review » Fixed

Hi Fonteijne,

Committed, thanks for the contribution!

daften’s picture

daften commented

I created 2.0.0-alpha2 to make installing this on PHP7.3 a bit easier.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.