Motivation

The current way we use some code from EntityFormDisplay but not all of it is confusing and difficult to maintain.

Proposal

  • Implement EntityFormDisplayInterface
  • Extend EntityDisplayBase instead for EntityFormDisplay.

Comments

rlmumford created an issue.

andrewbelcher’s picture

andrewbelcher commented

Let's also add test coverage by extending \Drupal\KernelTests\Core\Entity\EntityDisplayFormBaseTest with flexiform enabled.

andrewbelcher’s picture

andrewbelcher commented

Let's also add some kind of test that will notify us of upstream changes to EntityFormDisplay, perhaps with a hash of the class and a risky if it changes?

rlmumford’s picture

rlmumford
Primary language English
Location Manchester
commented

Look into what core tests we should run with flexiform enabled. From a quick look, these two are candidates:

\Drupal\FunctionalTests\Entity\ContentEntityFormCorrectUserInputMappingOnFieldDeltaElementsTest
\Drupal\FunctionalTests\Entity\ContentEntityFormFieldValidationFilteringTest