After enabling only the flagging_form module, can't save the flag edit form, get: "An illegal choice has been detected. Please contact the site administrator."

It happends, because there are $interactions = array(); definition, and if there isn't any hook, implements hook_flagging_form_interactions, in form the module try to show an options without any 'option'.

CommentFileSizeAuthor
#4 1624864_4_illegal_choice.patch607 bytesszantog
#3 1624864_3_illegal_choice.patch1.94 KBszantog
#1 1624864_1_illegal_choice.patch1.49 KBszantog

Comments

szantog’s picture

szantog commented
StatusFileSize
new 1624864_1_illegal_choice.patch1.49 KB

Patch
Marked as critical, because this completely breaks the flag edit form functionality.

szantog’s picture

szantog commented
Status: Active » Needs review

and needs review

szantog’s picture

szantog commented
StatusFileSize
new 1624864_3_illegal_choice.patch1.94 KB

Hmm, not so perfect. After enabled the dialog module, can't set to default.

szantog’s picture

szantog commented
StatusFileSize
new 1624864_4_illegal_choice.patch607 bytes

fix patch..

goron’s picture

goron commented

I believe the issue here is actually #1651342: Misnamed function in flagging_form module, and should be fixed by the patch there

szantog’s picture

szantog commented
Status: Needs review » Closed (duplicate)

You are totally right, nice catch!
I close this.