While reviewing this module for #1560010: [META] Port issue following functionality to D7 I noticed a few minor code style bugs:

A) } else { shows up a few times

B) There are places that use " for strings that don't need them (don't know why anyone cares, but it's part of the standard).

C) *Implements hook_flag(). needs a space.

D) Speaking of those kinds of doc blocks, there's a mix of "Implements ..." "Implementation of ..." and "Implement ..." -- the standard in D7 is "Implements hook...".

CommentFileSizeAuthor
#1 1828568-1.flag_tracker_code_style.patch4.67 KBdww

Comments

dww’s picture

Assigned: Unassigned » dww
Status: Active » Needs review
StatusFileSize
new4.67 KB

E) There were also a few lingering references to "issue" in the code and UI. Also removed.

Any objections to pushing this?

Thanks!
-Derek

dww’s picture

Status: Needs review » Fixed

Pushed to the 7.x-1.x branch:

http://drupalcode.org/project/flag_tracker.git/commit/ee9166c

Cheers,
-Derek

Automatically closed -- issue fixed for 2 weeks with no activity.