While reviewing this module for #1560010: [META] Port issue following functionality to D7 I noticed a few minor code style bugs:
A) } else { shows up a few times
B) There are places that use " for strings that don't need them (don't know why anyone cares, but it's part of the standard).
C) *Implements hook_flag(). needs a space.
D) Speaking of those kinds of doc blocks, there's a mix of "Implements ..." "Implementation of ..." and "Implement ..." -- the standard in D7 is "Implements hook...".
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1828568-1.flag_tracker_code_style.patch | 4.67 KB | dww |
Comments
Comment #1
dwwE) There were also a few lingering references to "issue" in the code and UI. Also removed.
Any objections to pushing this?
Thanks!
-Derek
Comment #2
dwwPushed to the 7.x-1.x branch:
http://drupalcode.org/project/flag_tracker.git/commit/ee9166c
Cheers,
-Derek