Closed (fixed)
Project:
Flag Note
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
30 Jan 2010 at 18:10 UTC
Updated:
19 Nov 2010 at 14:19 UTC
Jump to comment: Most recent file
What would be great is if there's a way for admins to predefine selectable notes and for flaggers to be able to select one of those notes.
That would enable something like #671808: Flag States wouldn't it?
Thanks.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | flag_note_699946_6_1x_2.patch | 5.98 KB | Ravi.J |
| #8 | flag_note-699946_6_2x.patch | 5.05 KB | Ravi.J |
| #7 | flag_note_699946_2.patch | 6.4 KB | Ravi.J |
| #6 | flag_note_699946.patch | 6.44 KB | Ravi.J |
Comments
Comment #1
gunzip commentedi will look at this (it requires some time)
Comment #2
ManyNancy commentedTerrific, thank you so much.
Comment #3
ManyNancy commentedThis feature would be really awesome for me. Would it be possible to do? Thanks.
Comment #4
loze commentedWhat about the ability to choose a taxonomy for each flag type that is "notes enabled"?
then each notes form could use the terms as the choices along with the textarea. it would have to store the tid.
for my purpose i want to have a select box of options as well as a "more details" text area for each piece of content being flagged.
Comment #5
Ravi.J commentedI am working on a patch that provides ability to choose a Vocabulary term per flag and still have the text area.
I am close to completing this, will post patch soon.
Comment #6
Ravi.J commentedAttached is patch that allows for predefined reasons via vocabulary terms.
Also provides a view relationship for predefined reasons
This patch is for version 6.x.1.x
Comment #7
Ravi.J commentedFixed a bug with help text second patch for version 6.x.1.x
Comment #8
Ravi.J commentedPatch for 6_2.x version
Comment #9
hagner commentedWorks for me. Thanks Ravi!
Comment #10
rickvug commentedI've also seen this working in action. It looks quite good. Certainly a +1 from me.
Comment #11
rickvug commented@Ravi.J - Note that the patch contains a .project file from your IDE. You'll want to remove that from the patches (setting to "needs work). Reading the code it looks clean so hopefully this will move to RTBC next.
Comment #12
Ravi.J commentedReattaching cleaned 6.x.1.x patch 6.x.2.x seems to be fine
Comment #13
gunzip commentedthank you for your work @ravi, i'll integrate this asap.
(i think it needs an update call to upggrade the db schema with the tid)
the latest patch gives this anyway against latest dev:
patching file flag_note.views.inc
Hunk #1 FAILED at 135.
i think because of wrong path.
Comment #14
Ravi.J commentedThere are couple of patches there, #8 is for 2.x branch and #11 is for 1.x branch. Please advice which one of them is failing and i will prepare another one.
Comment #15
gunzip commentedsorry it was my fault, both patches apply correctly.
Comment #16
Ravi.J commentedgr8 .. i have also put a patch for another issue #933556: default note text with token support
Comment #17
gunzip commentedi've applied the predefined notes patch (with some twists) for 6.2-dev release.
backporting to 6.1 needs some other work, i'll do that asap.
i've seen the other patch, i'll try to integrate that one as well,
thank you again =)
Comment #18
gunzip commentedbackported to 6.1-dev
Comment #19
glitz commentedThis very much sounds like it will help me accomplish what I need to do, as long as I can include a use pre-defined notes (which I understand I can) and incorporate those predefined notes into views.
i like to show on a users profile page, the node where the flag took place, and also display the predefined note they selected in the dropdown.
thanks,
chris
Comment #20
glitz commentedi jujst installed the latest version, but i dont see a place to add values for a selection box...
Help?!
Comment #21
gunzip commentedyou have to create a taxonomy and add some terms for that
Comment #22
glitz commentedhi. THANKS!!
yes it did, that and it is now working but, it there a way to not make the Flag note textarea required to fill out? I'd like to give the user an option of using just the selection box, but also add a note if they wish...
Comment #23
gunzip commentedactually there's no setting to change that. there are a couple of a workaround
1. use YOURMODULE_form_alter() function
2. hack the flag_note.module code changing line 167 to '#required' => FALSE,
Comment #24
glitz commentedI tried the following:
hack the flag_note.module code changing line 167 to '#required' => FALSE,
I cleared cache, and and It still appears to be required. Is there anywhere else I need this in flag_note.module?
thanks
Comment #25
glitz commentedpossibly line 447 as well?
'#required' => TRUE,
Comment #26
gunzip commentedyes, sorry it's this code