Problem/Motivation

Parameter order in FinderConfigManager and the methods called on FinderTypeInterface is a bit sloppy.

It should be:

1. The thing being made or altered, such as an ID or config values
2. Its dependencies in order from closest, leading to the finder.

So, e.g.:

- view exposed block ID
- View
- Finder

We should pass the finder rather than the finder type, so overrides of either the service or plugins can access the finder configuration.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

joachim created an issue. See original summary.

joachim’s picture

Issue summary: View changes
joachim’s picture

Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • joachim committed af4d6728 on 1.0.x
    task: #3590697 standardize parameter order in config manager
    
    By: joachim