Problem/Motivation

ajax form rebuild.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork feeds_migrate-3194181

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ipumpkin created an issue. See original summary.

ipumpkin opened merge request !3

megachriz’s picture

megachriz
Primary language Dutch
commented

@ipumpkin
That's a huge amount of changes! Can you explain in more detail what you are changing and why? Is something related to updating form elements not working properly? What form elements on which form do not get updated? Can you provide the steps to reproduce the bug?

Thanks for your contribution.

ipumpkin’s picture

ipumpkin
Primary language Chinese, Simplified
Location China
commented

@MegaChriz, It indeed has changed a lot, the main goal for this rebuild is remove the copyFormValuesToEntity logic in form plugin , and rebuild in submitConfigurationForm menthod, the form plugin should not change the entity directly ,prepare values in form submit is better.

There has a ajax form issue on importer create form:
1. open the importer create form /admin/content/feeds-migrate/importer/add
2. select a migration in "Migration Source"
3.switch anthor migration n "Migration Source"
4. the migration's settings not changed

ipumpkin’s picture

ipumpkin
Primary language Chinese, Simplified
Location China
commented
Status: Active » Needs review

Need review, no idea for the test -_-