I would suggest to define all implicit mappings (mappings that FeedAPI node does by default) as FEMP default mappings if FEMP 2.x is present. Will post a first patch soon.

I see that e. g. if "Published time" mapping target is defined, FeedAPI node still overrides it. This only loosely related, but I think we should address this issue in one go.

CommentFileSizeAuthor
#3 591434-3_support_default_mappings_all_targets.patch2.8 KBaron novak
#1 591434-1_support_default_mappings_all_targets.patch1.78 KBalex_b

Comments

alex_b’s picture

alex_b commented
Status: Active » Needs work
StatusFileSize
new 591434-1_support_default_mappings_all_targets.patch1.78 KB

- adds all mappings
- missing: fix _feedapi_node_save() to respect mappings.

alex_b’s picture

alex_b commented

Breaks FeedAPI Mapper tests as they try to specify the same mappings.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs work » Needs review
StatusFileSize
new 591434-3_support_default_mappings_all_targets.patch2.8 KB

This one looks good.
Added the ability to override $node->created, i agree that this belongs to this ticket.

Follow-up issue: #594130: Tests: handle already existing mappings