While the automated tests, it's not really valid to call module_invoke() because it may call such modules that are not enabled inside the test sandbox.

Comments

aron novak’s picture

Status: Active » Needs review
StatusFileSize
new3.42 KB

Tests are passed, a new approach is used in testKeepNodeSettingsAtUpdate().

alex_b’s picture

"module_invoke() because it may call such modules that are not enabled inside the test sandbox"

I don't see how this could happen - what am I missing here?

What did you replace module_invoke() with?

aron novak’s picture

#2: module_ivoke uses that the Drupal instance of the live site. Normally when use use simplepie's browser, it uses another virtual Drupal instances. This is really possible that you have a lot of modules enabled in your live site, but in the virtual Drupal, simpletest only installs and enables those modules what are you specify in setUp().

I replaced that function call with a self-modifying RSS feed :) This is hosted externally, just as the other test feeds.

aron novak’s picture

Priority: Normal » Critical

This is such a patch what I would like to see in FeedAPI 1.9.

aron novak’s picture

StatusFileSize
new3.57 KB

I rerolled this patch after #499680: Restructure tests

alex_b’s picture

Status: Needs review » Reviewed & tested by the community

RTBC

aron novak’s picture

Status: Reviewed & tested by the community » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.