For debugging, it is sometimes very useful to monitor memory usage on cron feed processing.

I propose to monitor memory increase while processing feeds. Will post patch shortly.

CommentFileSizeAuthor
#9 503242-8_new_stats.patch2.8 KBaron novak
#8 503242-7_new_stats.patch2.05 KBalex_b
#7 503242_changelog_change.patch771 bytesaron novak
#6 503242-6_measure_mem.patch1.68 KBalex_b
#5 503242-5_measure_mem.patch1.68 KBalex_b
#4 503242-4_measure_mem.patch3.19 KBalex_b
#1 503242-1_measure_mem.patch1.07 KBalex_b

Comments

alex_b’s picture

alex_b commented
StatusFileSize
new 503242-1_measure_mem.patch1.07 KB
alex_b’s picture

alex_b commented
Assigned: alex_b » Unassigned
Status: Active » Needs review
aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs review » Reviewed & tested by the community

(PHP 4 >= 4.3.2, PHP 5) memory_get_usage - php.net
Required: PHP version 4.3.5 or higher - d.o

Then RTBC.

alex_b’s picture

alex_b commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 503242-4_measure_mem.patch3.19 KB

Why do we actually only store stats if there are $new items?

Pending: php version checking.

alex_b’s picture

alex_b commented
StatusFileSize
new 503242-5_measure_mem.patch1.68 KB

Patch in #4 contained unrelated changes.

alex_b’s picture

alex_b commented
StatusFileSize
new 503242-6_measure_mem.patch1.68 KB

Better comment wording.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
StatusFileSize
new 503242_changelog_change.patch771 bytes

Let's explain the change of the meaning of update rate field at the admin interface.

alex_b’s picture

alex_b commented
Title: Measure memory usage » Adjust stat logging
StatusFileSize
new 503242-7_new_stats.patch2.05 KB

Ok, this is growing out to be a more comprehensive overhaul of the statistics logging:

- Log not only if there are new items
- Log next refresh time
- Log growth in memory usage

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 503242-8_new_stats.patch2.8 KB

Unified patch of #8 and #7
Seems to be okay.

alex_b’s picture

alex_b commented

RTBC from my point of view, too.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.