_feedapi_populate() kills default settings on the node type settings form. feedapi_node_feedapi_settings_form() expects the story content type to be present. Both behaviors create fatal errors when trying to import a feedapi content type with content copy. The attached patch fixes these problems.

We're running on production with this patch right now. Haven't heard from problems yet :)

Would appreciate someone out there testing it so we can roll it into version 1.3. The patch is against 5.x, should be applicable to 6.x as well (haven't tried it though).

CommentFileSizeAuthor
content_copy_compatible.patch1.79 KBalex_b

Comments

mustafau’s picture

mustafau commented

Following part of the patch is a duplicate of; #282476: PHP notices in FeedAPI and #276996: Warnings and Notices

RCS file: /cvs/drupal-contrib/contributions/modules/feedapi/feedapi.module,v
retrieving revision 1.23.2.132
diff -u -r1.23.2.132 feedapi.module
--- feedapi.module	9 May 2008 13:30:07 -0000	1.23.2.132
+++ feedapi.module	28 Jul 2008 13:08:15 -0000
@@ -1348,7 +1348,7 @@
             // respect #parents if set
             $form[$k]['#default_value'] = _feedapi_populate_get_setting($form[$k]['#parents'], $settings);
           }
-          else {
+          else if (isset($settings[$k])) {
             $form[$k]['#default_value'] = $settings[$k];
           }
         }
mustafau’s picture

mustafau commented

The other part is a duplicate of #282816: Add a setting to specify default content type for feed items

mustafau’s picture

mustafau commented
Status: Needs review » Closed (duplicate)

Duplicate of three issues with attached patches. One of them is RTBC.