More complicated fapi elements that have #parents to define where their values get stored [for example the formatting options outputted by filter_form()] do not get populated with a #default_value. They in fact get any #default_value set clobbered.

Patch respects of #parents array if it exists, and uses it to get any $settings that might exist.

CommentFileSizeAuthor
feedapi.20080501.patch2.13 KBekes

Comments

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs review » Fixed

Thank you, i committed the patch. The patch is fine according to the coder module and it passes the simpletest tests too. :)
Can i ask you to test the fix w/ 6.x-1.x-dev branch too?

mustafau’s picture

mustafau commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Active

Following notice appears in 6.x-1.x;

notice: Undefined index: #parents in feedapi.module on line 1349.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Component: Code » Code feedapi (core module)
Status: Active » Fixed

This notice is killed now.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Fixed » Closed (fixed)