Tags from delicious feeds

Someone already implemented this for simplepie. If someone can figure out how to include the proper inc file this could be fixed very quickly: http://simplepie.org/wiki/addons/del.icio.us.

Can someone tell me where to add the include for this file in the current feedapi module?

Hey Bill,

This issue should be solved on the FeedAPI level. The tags in (I hope I remember the location correctly) ->options->tags should be always split up correctly.

I haven't experimented with delicious feeds yet. Maybe the solution that yellek points to just works. Not knowing how exactly to include simple pie add ons, FeedAPI's parser_simplepie.module would be the place to include it in.

I would appreciate any experiences/feedback here. I will push this issue to FeedAPI.

Thanks for your help,

Alex

I did some experimentation with this and managed to get it to work. As this is the first time I have ever written PHP please let me know if I am making beginner mistakes.

Steps required:

1. Create a simplepie_delicious.inc file in the feedapi/parser_simplepie directory
2. Copy the PHP code from http://simplepie.org/wiki/addons/del.icio.us#add-on_source_code into the file and save it
3. Edit feedapi/parser_simplepie/simplepie.module (edited source shown below)
4. After line 181 add the line require_once(drupal_get_path('module', 'parser_simplepie') .'/simplepie_delicious.inc');
5. Add the line $parser->set_item_class('SimplePie_Item_Delicious');

The complete modified function is below:

/**
 * Set SimplePie setting
 * @param $url
 *  The feed's url
 * @return
 *  SimplePie object
 */
function _parser_simplepie_get_parser($url) {
  require_once(drupal_get_path('module', 'parser_simplepie') .'/simplepie.inc');
  require_once(drupal_get_path('module', 'parser_simplepie') .'/simplepie_delicious.inc');
  $parser = new SimplePie();
  $parser->set_feed_url($url);
  $parser->set_timeout(15);
  $parser->set_stupidly_fast(TRUE);
  $parser->encode_instead_of_strip(FALSE);
  $cache_location = _parser_simplepie_sanitize_cache();
  $parser->enable_cache($cache_location !== FALSE ? TRUE : FALSE);
  $parser->set_cache_location($cache_location);
  $parser->set_item_class('SimplePie_Item_Delicious');
  $parser->init();
  return $parser;
}

This works for me but I will leave it to more experienced PHP coders to tidy it up for inclusion in the source.

yellek

At a quick glance this seems it would interpret all simplepie feeds as though they were delicious feeds ie. spaced instead of commas.

I think this is a very good first step but I believe it needs a bit more work on the internals so that feeds are optionally (and appropriately) interpreted in the 'delicious' format. I'm not sure what the best method for that is; right now all that is coming to mind is a whitelist by type/url, or a select choice when the user sets the feed. I think the user selectable option is better as it is more extensible, but hiding unnecessary options from users is always good too.

I'm digging to see if there is a way to appropriately detect the format on the backend and optionally include 'simplepie_delicious.inc' and call $parser->set_item_class('SimplePie_Item_Delicious'); this would avoid exposing an unnecessary option to the user.

From a quick look the only obvious thing I'm seeing is the url, but that is a kludgey way to do it that would suggest a user option is much better.

Will post back as new info becomes available.

Well, just for the heck of it, attached are patch and the simplepie_delicious.inc files to build off of

The funny thing is, I can't actually get this to *work*...