Thanks for great module! I made some testing. Here are my suggestions:

  • I think a comment form must be hidden by default (on views, not on status page). When user click to "Comment" link, form will expand. Now it looks a bit strange (see screenshot).
  • A separate "Comments" link (link to status page) will be useful for blocks. "Comments (comment count)" looks better, but then extra database table will be required. Something like node_comment_statistics. This also allow to sort statuses by last comment time. What are you thinking about it?
  • "Show all comments" link looks pretty good. You can use this feature for status page too (display only 10 [for example] last comments by default, if user not click to "Show all comments", but click to "Comments" link on some block)
CommentFileSizeAuthor
#4 fbssc.patch3.1 KBGyt
#2 comment_links.png8.73 KBGyt
#1 fbssc_listing.png19.31 KBicecreamyou
manyforms.png18.81 KBGyt

Comments

icecreamyou’s picture

Status: Active » Fixed
StatusFileSize
new19.31 KB

#1 is already in the alpha build.

What you're thinking of in #2 is already possible using Views.

I intentionally chose to show all comments on the individual status pages because the entire point of those pages is to read the whole thread.

Gyt’s picture

Status: Fixed » Active
StatusFileSize
new8.73 KB

#1 is already in the alpha build.

Yes, but comment form is hidden only if status don't have any comments. Otherwise, form with "Share" button appears. I have some trouble with AJAX refresh, when I try to replace this form with "Comment" link, but I think it will look much better (see screenshot).

icecreamyou’s picture

Ohh. Yeah, okay, I'll work on that.

Gyt’s picture

StatusFileSize
new3.1 KB

I use drupal collapsed fieldset for that feature. User can add only one comment per status without page refresh. So it's antispam (and antiflood) solution.

icecreamyou’s picture

Well, I'm definitely not going to do it that way. Fieldsets carry too much baggage. And I'm also not going to make people refresh the page. This is easy to do with JQuery's $(element).show(), I just haven't gotten around to it.

icecreamyou’s picture

Title: Some suggestions » Always hide comment box initially

Renaming this issue to make it easier to find and understand.

icecreamyou’s picture

Status: Active » Fixed

Just committed a fix for this to CVS.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.