Closed (fixed)
Project:
Fasttoggle
Version:
7.x-1.5
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Aug 2014 at 04:26 UTC
Updated:
24 Nov 2014 at 11:54 UTC
Jump to comment: Most recent
Installed 7x1.5... All threads fail to theme now when Advanced Forum is enabled. Disabling Adv Forum allows threads to display but .... I'm themed for AF.
Had to uninstall.
Speaking of uninstall... I should open another issue, but fasttoggle comment module has itself as a dependency. Can't uninstall unless you manually edit the depend. out of the info file.
(Using AF 7x 2.3)
Comments
Comment #1
aharown07 commentedComment #2
nigelcunningham commentedWhat theme are you using? I'm unable to reproduce any issue with Garland.
Comment #3
aharown07 commentedThe Adv Forum theme is basically "naked"
Site theme is Corolla
Problems seem to only appear when I have AF enabled. Hoping to get a chance soon to test w/updated AF.
Comment #4
nigelcunningham commentedOk. Perhaps the problem is that I'm trying an AF version that's too new (dev IIRC). What version are you using?
Comment #5
aharown07 commentedI'm using 7x 2.3
Haven't yet tested w/ 2.4, but it looks like a handful of fixes in that release that should not make a difference w/this.
Comment #6
nigelcunningham commentedWould you be using PHP 5.3?
I used a PHP 5.4 feature in the Fasttoggle 1.5 release, and that's reverted in -dev. Perhaps that will be the issue.
Comment #7
aharown07 commentedYes, that could be it. I'm on PHP 5.3
Comment #8
nigelcunningham commented7.x-1.6 has been released, with that fix included. Would you please give it a try?
Comment #9
aharown07 commentedMany thanks. Will give that a spin shortly. Maybe later this evening.
Comment #10
aharown07 commentedTried 1.6 last night and got the same result.
I think what I need to do is get to work on a test site updating Adv Forum and Fasttoggle w/most other modules disabled and see what happens.
Comment #11
nigelcunningham commentedPlease try current -dev; I've just pushed a contextual links related fix.
Comment #12
aharown07 commentedWill do that soon. I have my AF updated now, too.
Comment #13
aharown07 commentedTested with the dev version. It's still breaking the css in individual forum threads. The forum lists and topic lists seem to have no problem. A couple of things I haven't experimented much with yet: switching site theme, testing all the different AF themes (have tested a couple), checking the css aggregation settings.
More on that shortly.
Update: no, the AF theme selection doesn't make a difference, nor does disabling css aggregation or clearing all the caches.
Switching the main site theme to Garland also had no impact.
Comment #14
nigelcunningham commentedThanks for the feedback.
Would you please give me some specific pages to look at for the issue? I'm not an AF user, so I might be looking in the wrong place in trying to see/fix this issue.
Also is it just CSS that's broken? Do the links and the rest of the page otherwise work okay?
Comment #15
aharown07 commentedI may have misstated the result. The CSS definitely breaks but once I scroll past the menus etc, it's clear that the actual node is not posting.
Here's a test link I can keep active for a while:
http://test.sharperiron.org/article/test-1
Comment #16
aharown07 commentedFurther testing. Started turning random modules off. Apparently the problem is not AF but rather Author Pane. If I disable Author Pane, everything seems to load normally.
The version of AP I'm using is 7x-2.0
Comment #17
aharown07 commentedComment #18
nigelcunningham commentedHow do you have author pane configured? I've just added it under Garland and am not seeing any adverse effects straight away.
Comment #19
aharown07 commentedThere doesn't appear to be anything to configure. But the problem does not occur until both Author Pane and Advanced Forum are enabled.
Looks like there is no config in AF for it either. The AF templates use APane automatically if it's enabled.
There is one config option in AF that appears to make some difference: you can select which content types to use AF for. You can also select whether to use it on all comments.
So if I disable AF on one of my content types (but still have it set to style all comments), the node does actually load... css still breaks though.
(And the comments do not appear at all)
Comment #20
nigelcunningham commentedIt should be fixed now. Please try the latest commits on the 7.x-1.x branch.
I don't see any actual fasttoggle links in the authorpane; author-pane.tpl.php is looking for a variable named fasttoggle_block_author but doesn't seem to have anything to set it.
Comment #21
nigelcunningham commented