Looking at other CKEditor plugin modules and some of the documentation on drupal.org, it seems to be a defacto standard to have ckeditor plugins in libraries/ckeditor/plugins/pluginname.

This makes sense since it removes the risk of confusion and conflicts with non-ckeditor libraries that might have the same name and CKEditor's default instructions are to put plugins in a plugins sub-directory, which is what Drupal core does with its default CKEditor plugins.

If we can get consistency with where CKEditor plugin modules store their libraries it also makes it easier to manage all CKEditor plugins in a uniform manner.

CommentFileSizeAuthor
#11 support_alt_library_location-3046776-11.patch4.34 KBrromore
#10 support_alt_library_location-3046776-10.patch4.32 KBrromore
#7 support_alt_library_location-3046776-7.patch4.99 KBrromore
#6 support_alt_library_location-3046776-6.patch4.91 KBrromore
#5 support_alt_library_location-3046776-5.patch4.58 KBrromore
#2 support_alt_library_location-3046776-2.patch4.57 KBrromore

Comments

rooby created an issue. See original summary.

rromore’s picture

rromore commented
StatusFileSize
new support_alt_library_location-3046776-2.patch4.57 KB

This patch requires https://www.drupal.org/files/issues/fakeobjects-use_libraries_to_locate_... from https://www.drupal.org/project/fakeobjects/issues/2875374.

rromore’s picture

rromore commented
Related issues: +#2875374: Use Libraries to locate plugin
rooby’s picture

rooby commented

Thanks for the patch. I was hoping to get to this last weekend but I'll definitely have time this weekend, so I will review then.

rromore’s picture

rromore commented
StatusFileSize
new support_alt_library_location-3046776-5.patch4.58 KB

I mistakenly used "Error" instead of "Exception" with my last patch. Attaching a new patch with the correction.

rromore’s picture

rromore commented
StatusFileSize
new support_alt_library_location-3046776-6.patch4.91 KB

Found a few more issues including plugin path resolution and not checking for profile plugin path in actual plugin.

rromore’s picture

rromore commented
StatusFileSize
new support_alt_library_location-3046776-7.patch4.99 KB

Fixing a php notice on status report page.

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented
Related issues: +#3067741: Support multiple library paths

Looking at other CKEditor plugin modules and some of the documentation on drupal.org, it seems to be a defacto standard to have ckeditor plugins in libraries/ckeditor/plugins/pluginname.

Hi @rooby. Could yu please provide links to the documentan you were looking at?

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented

Documentation would be good. I know for example that Webform module uses fakeobjects plugin, but it installs it to /libraries/ckeditor.fakeobjects, and not in a ckeditor-specific directory.

rromore’s picture

rromore commented
StatusFileSize
new support_alt_library_location-3046776-10.patch4.32 KB

Updating patch based on changes made to the anchor_link module.

rromore’s picture

rromore commented
StatusFileSize
new support_alt_library_location-3046776-11.patch4.34 KB

Fixing a syntax issue with the previous patch.