We could be using README.md instead of README.txt to make use of the nicer rendering via markdown.

Now that we've moved to GitLab, we should probably use Markdown instead of plain .txt files for our documentation

Follow the pattern in the README.md template.

CommentFileSizeAuthor
#6 interdiff_4-6.txt299 bytesakram khan
#6 3337791-6.patch1.33 KBakram khan

Issue fork facets_range_input-3337791

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Jay Jangid created an issue. See original summary.

Jay Jangid opened merge request !4

jay jangid’s picture

jay jangid commented
Assigned: jay jangid » Unassigned
Status: Active » Needs review

Created MR , please review.

Thank you.

Sonal Gyanani’s picture

Sonal Gyanani commented
Status: Needs review » Reviewed & tested by the community

Thanks @Jay Jangid, MR looks good to me so moving it to RTBC

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Reviewed & tested by the community » Needs work

The "configuration" section of the readme should describe that the Range Input widget needs to be selected for a relevant facet, and the Range Input processor be selected, for this to work.

akram khan’s picture

akram khan
Primary language English
Location Cuttack, Odisha
commented
StatusFileSize
new 3337791-6.patch1.33 KB
new interdiff_4-6.txt299 bytes

updated patch consider #5

himanshu_jhaloya made their first commit to this issue’s fork.

himanshu_jhaloya opened merge request !5

himanshu_jhaloya’s picture

himanshu_jhaloya commented
Assigned: Unassigned » himanshu_jhaloya
Status: Needs work » Needs review
himanshu_jhaloya’s picture

himanshu_jhaloya commented
Assigned: himanshu_jhaloya » Unassigned
Anmol_Specbee’s picture

Anmol_Specbee commented
Status: Needs review » Reviewed & tested by the community

Patch is working as expected. Moving to RTBC.

svendecabooter changed the visibility of the branch 3337791-replace-readme.txt-to to hidden.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Reviewed & tested by the community » Needs work

The "configuration" section of the readme should describe that the Range Input widget needs to be selected for a relevant facet, and the Range Input processor be selected, for this to work.

The help text in MR #5 does not correctly reflect this.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented