CommentFileSizeAuthor
#8 facebook_comments_block-add_language_settings_d8-2829445-8.patch20.33 KBmqanneh
#4 language-settings_2829445_2.patch11.73 KBJFKiwad
#2 language-settings_2829445_1.patch11.99 KBJFKiwad

Comments

JFKiwad created an issue. See original summary.

JFKiwad’s picture

JFKiwad
Location Montreal
commented
StatusFileSize
new language-settings_2829445_1.patch11.99 KB

Note : Many lines have been modified due to the "auto format space" in Sublime Text.

Status: Needs review » Needs work

The last submitted patch, 2: language-settings_2829445_1.patch, failed testing.

JFKiwad’s picture

JFKiwad
Location Montreal
commented
StatusFileSize
new language-settings_2829445_2.patch11.73 KB

There was simply a path problem. Hope this one works

JFKiwad’s picture

JFKiwad
Location Montreal
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: language-settings_2829445_2.patch, failed testing.

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Assigned: Unassigned » mqanneh
mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
StatusFileSize
new facebook_comments_block-add_language_settings_d8-2829445-8.patch20.33 KB

Added language setting.

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Assigned: mqanneh » Unassigned
Status: Needs work » Fixed

  • mqanneh committed ad64e16 on 8.x-1.x 
    Issue #2829445 by mqanneh: Add language settings D8
mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Status: Fixed » Closed (fixed)

Fixed.