Overview

@jessebaker reported that Cypress tests fail to install on 11.0:

$ php ../../../core/scripts/test-site.php install --setup-file "modules/contrib/experience_builder/tests/src/TestSite/XBTestSetup.php" --install-profile "nightwatch_testing"  --base-url http://localhost:8888/ --db-url sqlite://localhost/sites/default/files/db.sqlite --json

In ConfigSchemaChecker.php line 98:
                                                                                                                                                                                             
  Schema errors for experience_builder.component.block.system_branding_block with the following errors: 0 [settings.settings] 'status' is a required key., 1 [settings.settings]   
  'info' is a required key., 2 [settings.settings] 'view_mode' is a required key., 3 [settings.settings] 'context_mapping' is a required key.

Since blocks as components landed, we are running into #3379725: Make Block config entities fully validatable here - blocks no longer have 'status', 'info' and 'view_mode' keys, but the schema says they do in 11.0. This is solved in 11.1 - though not sure why it's not affecting 10.x?

Proposed resolution

Either: raise the minimum version to ^10.4 | ^11.1
Or: figure out a fix that works on both versions

User interface changes

Issue fork experience_builder-3487745

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave credited jessebaker.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Config schema is not valid in Drupal 11.0 » Config schema is not valid in Drupal 11.0 — bump minimum XB version to 11.1
Assigned: Unassigned » lauriii
Issue tags: +Needs product manager review
Related issues: +#3473343: Switch our base to Drupal 11

+1 for

raise the minimum version to ^10.4 | ^11.1

This would allow us to remove a LOT of work-arounds that are increasingly slowing us down.

The Starshot project also bumped their minimum to 11: #3473343: Switch our base to Drupal 11.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue tags: -Needs product manager review

It seems fine to raise the minimum requirement to the latest minor of Drupal 10 and 11 ^10.4 || ^11 to ^10.4 | ^11.1.

longwave opened merge request !408

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

Possible trivial fix for this issue that lets us continue on 11.0 for now in MR!408.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

Let’s also bump the version requirement while we have the necessary +1s? 🤓

tedbow made their first commit to this issue’s fork.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

LGTM.

  • tedbow committed 9dda9d46 on 0.x authored by longwave 
    Issue #3487745 by longwave, wim leers, lauriii, jessebaker: Config...
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Reviewed & tested by the community » Fixed
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: lauriii » Unassigned
Issue tags: +Configuration schema, +validation

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.