Toolbar Integration Broken

Problem/Motivation

Changes from 4.0.25 to 4.1 (RC1) prevent the "non-toolbar" environment indicator from displaying for users who do not have access to view the toolbar.

Steps to reproduce

Configure a site (core 10.6.9 in my case):

• Users/roles who utilize the core toolbar
• Users/roles who do not utilize the core toolbar
• Environment indicator and toolbar submodule installed
• Environment indicator accessible to users/roles who do not have access to toolbar

Expected:

Users who have access to environment indicator but not toolbar, little banner with environment indicator color/info.

Actual:

Users who have access to environment indicator but not toolbar, see no environment indicator.

Proposed resolution

Adjust the logic in environment_indicator_page_top to properly detect toolbar integration and access/visibility. When the user does not have the toolbar, they should "fallback" to showing the little banner w/environment indicator color/info.

Remaining tasks

Code change, review, testing, etc.

User interface changes

Changes to reflect previous behavior:

Users who have access to environment indicator and toolbar, see the toolbar with environment indicator color/info.

Users who have access to environment indicator but not toolbar, little banner with environment indicator color/info.

API changes

None expected.

Data model changes

None expected.