warnings in entityreference_view_widget_validate() on node save [#1393548]

When I save a node having selected some entities, I get these warnings:

    Notice: Undefined index: add in entityreference_view_widget_validate() (line 493 of /Users/joachim/Sites/7-drupal/sites/all/modules/contrib/entityreference_view_widget/entityreference_view_widget.module).
    Warning: array_filter() expects parameter 1 to be array, null given in entityreference_view_widget_validate() (line 493 of /Users/joachim/Sites/7-drupal/sites/all/modules/contrib/entityreference_view_widget/entityreference_view_widget.module).
    Warning: Invalid argument supplied for foreach() in entityreference_view_widget_validate() (line 494 of /Users/joachim/Sites/7-drupal/sites/all/modules/contrib/entityreference_view_widget/entityreference_view_widget.module).

Comment	File	Size	Author
#2	[dont_proccess_empty_add_array_on_save]-[1393548]-[5438396].patch	933 bytes	barry_fisher

Comments

Comment #1

barry_fisher commented 6 January 2012 at 18:01

I've just created a patch for this that basically avoids processing an empty $element_values['add'] array when all possible right hand side entities are selected (or if none exist). $element_values['add'] is basically non-existent in this case.