The error message has a label that can't be translated.

Patch will follow.

CommentFileSizeAuthor
#6 add_i18n_support_for-2557039-6.patch1.26 KBspadxiii
#3 add_i18n_support_for-2557039-3.patch1.26 KBtessa bakker
#2 add_i18n_support_for-2557039-2.patch1.27 KBtessa bakker

Comments

Tessa Bakker created an issue. See original summary.

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new add_i18n_support_for-2557039-2.patch1.27 KB

Here is the patch.

Used $instance instead of $field_instance (#2206905: Notice when entity does not have bundle) and checked the message if it was consistent with Drupal Core (#2209127: Improve validation message). See also 'is required' messages in Drupal core.

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
StatusFileSize
new add_i18n_support_for-2557039-3.patch1.26 KB

And now with the correct message.

spadxiii’s picture

spadxiii commented
Status: Needs review » Reviewed & tested by the community

Looks good and works fine.

spadxiii’s picture

spadxiii commented

I missed a single error: $field['label'] does not exist. This should be $label = $instance['label'];

Other than that, this patch works fine.

spadxiii’s picture

spadxiii commented
StatusFileSize
new add_i18n_support_for-2557039-6.patch1.26 KB

Updated the patch with my findings.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Status: Reviewed & tested by the community » Needs work

form_set_error() is removed from this handler by #2558753: Change error handling; mark error on delta, not whole field so this will need a re-roll.