Remove entity_reference dependency

CommentFileSizeAuthor
#5 3101148-after-patch.png17.32 KBdevashish jangid
#5 3101148-before-patch.png17.62 KBdevashish jangid
#2 3101148-remove_entity_reference_dependency-1.patch388 byteslukasss

Comments

lukasss created an issue. See original summary.

lukasss’s picture

lukasss commented
StatusFileSize
new 3101148-remove_entity_reference_dependency-1.patch388 bytes
lukasss’s picture

lukasss commented
Status: Active » Needs review
guilopes’s picture

guilopes commented

why should we remove this? this module explicitly depends on entity_reference otherwise you can't even use it (the field type it applies to is entity_reference)

devashish jangid’s picture

devashish jangid commented
StatusFileSize
new 3101148-before-patch.png17.62 KB
new 3101148-after-patch.png17.32 KB

Verified and tested patch #2.
Patch applied successfully and looks good for me.
Sharing screenshot for the reference.
Moving this ticket to RTBC.

guilopes’s picture

guilopes commented

Devashish, please do not move to RTBC. I need to understand why we should remove this dependency. as I mentioned on #4

mkolar’s picture

mkolar commented
Status: Needs review » Reviewed & tested by the community

@guilopes this is RTBC, i just tested this module on D9 and entity_reference module is deprecated (/moved to core), looks like contrib modules should not set such dependencies anymore. It throws an error. WIth this patch, module works on D9 without problem.