When cloning a node the value is not detected and this module complains that the reference should be set via the URL

CommentFileSizeAuthor
#12 i2804439-12.patch1.42 KBattiks
#9 i2804439-9.patch840 bytesattiks
#4 i2804439-4.patch797 bytesattiks
#2 i2804439-2.patch1017 bytesattiks

Comments

attiks created an issue. See original summary.

attiks’s picture

attiks commented
Status: Active » Needs review
StatusFileSize
new i2804439-2.patch1017 bytes

Attached patch checks the items_count on the field

Status: Needs review » Needs work

The last submitted patch, 2: i2804439-2.patch, failed testing.

attiks’s picture

attiks commented
Status: Needs work » Needs review
StatusFileSize
new i2804439-4.patch797 bytes

Let's try this again

Status: Needs review » Needs work

The last submitted patch, 4: i2804439-4.patch, failed testing.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

THanks.

I think enough to do (!empty($value['items_count']). Also worth adding a comment why it's needed.

attiks’s picture

attiks commented

$value['items_count'] can be 0, so we need the $value['items_count'] > 0

attiks’s picture

attiks commented

nevermind, misread the empty part

attiks’s picture

attiks commented
Status: Needs work » Needs review
StatusFileSize
new i2804439-9.patch840 bytes

Status: Needs review » Needs work

The last submitted patch, 9: i2804439-9.patch, failed testing.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

I suspect the test is failing regardless. Just yesterday I had this one that might help

attiks’s picture

attiks commented
StatusFileSize
new i2804439-12.patch1.42 KB

attempt to fix the test

attiks’s picture

attiks commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: i2804439-12.patch, failed testing.

attiks’s picture

attiks commented

Failed, no idea why