In the case that you are using a features driven deployment and you are deploying the Entityform Block module without having exported the entitform_block_types variable to strongarm, you will/may get the following error:

in_array() expects parameter 2 to be array, null given entityform_block.module:151

The issue being that for whatever reason (feature revert most likely), the entityform_block_entity_delete() function is being triggered and the variable_get() function doesn't have a default value.

Fix is simple, always provide variable_get() with a default value. Patch incoming.

Comments

Deciphered created an issue. See original summary.

deciphered’s picture

Status: Active » Needs review
StatusFileSize
new1.25 KB
deciphered’s picture

StatusFileSize
new593 bytes
new1.68 KB

Missed one with last minute testing.

mxr576’s picture

Status: Needs review » Reviewed & tested by the community
mxr576’s picture

StatusFileSize
new1.68 KB

Quick and easy fix! Congrat!
I've fixed the name of your patch only, according to this: https://www.drupal.org/node/707484

deciphered’s picture

@mxr576,

While the name of the patch is as you said per the URL you linked, it is correct based on the format as defined by https://www.drupal.org/project/entityform_block/git-instructions.

Seems to me that was an unnecessary change.

mxr576’s picture

It was necessary from my side, because without the prefix of the project name I can not see which patch belongs to which module in my patches folder, when I need to update a module. I've published this minor change, because I think it will be useful for other ones. I know how a module description page look like, but that is why I've mentioned an other documentation with the other patch name convention, that I used to use.