Copy of TaxonomyTermTestCase (EntityCacheTaxonomyTermUnitTest) [Entity cache]
Should be
Copy of TaxonomyTermUnitTest (EntityCacheTaxonomyTermUnitTest) [Entity cache]

CommentFileSizeAuthor
#12 entitycache-n2378323-12.patch776 bytesdamienmckenna
#7 2378323-7.patch537 bytesPalashvijay4O
#5 2378323-3.patch598 bytesPalashvijay4O
#3 2378323-2.patch646 bytesPalashvijay4O
#1 2378323-1.patch678 bytesPalashvijay4O

Comments

Palashvijay4O’s picture

Palashvijay4O commented
Status: Active » Needs review
StatusFileSize
new 2378323-1.patch678 bytes

Patch .

Status: Needs review » Needs work

The last submitted patch, 1: 2378323-1.patch, failed testing.

Palashvijay4O’s picture

Palashvijay4O commented
Status: Needs work » Needs review
StatusFileSize
new 2378323-2.patch646 bytes

Wrong one .

Status: Needs review » Needs work

The last submitted patch, 3: 2378323-2.patch, failed testing.

Palashvijay4O’s picture

Palashvijay4O commented
Status: Needs work » Needs review
StatusFileSize
new 2378323-3.patch598 bytes

Just a test patch .

Status: Needs review » Needs work

The last submitted patch, 5: 2378323-3.patch, failed testing.

Palashvijay4O’s picture

Palashvijay4O commented
Status: Needs work » Needs review
StatusFileSize
new 2378323-7.patch537 bytes

Was Working on the wrong code .

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/entitycache.test
+++ b/entitycache.test
@@ -1232,8 +1232,8 @@ class EntityCacheTaxonomyTermUnitTest extends TaxonomyTermTestCase {

Oh that line should be probably adapted as well ... we extend the same test class twice.

Palashvijay4O’s picture

Palashvijay4O commented

@dawehner I am not clear why that should be added twice ...

dawehner’s picture

dawehner
Primary language German
commented

I would argue we need something like

EntityCacheTaxonomyTermUnitTest extends TaxonomyTermUnitTest {
Palashvijay4O’s picture

Palashvijay4O commented
Assigned: Unassigned » Palashvijay4O

I found no class with name **TaxonomyTermUnitTest** if i am correct.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new entitycache-n2378323-12.patch776 bytes

Another way of looking at it... there is no TaxonomyTermUnitTest so there's no need to do a "copy of TaxonomyTermUnitTest", that leaves us with two copies of TaxonomyTermTestCase so lets get rid of EntityCacheTaxonomyTermUnitTest.