Problem/Motivation

The cache metadata is incorrect on forms. Prior to #2578855: Form tokens are now rendered lazily, allow forms to opt in to be cacheable this did not matter as forms were not cached - but now they can be.

This MR also fixes the pipeline so it is green.

Steps to reproduce

Run tests

Proposed resolution

Add the correct cacheability metadata to the forms.

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

Issue fork entity_usage-3499592

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !95

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Fix gitlabci » Ensure caching metadata is correct on forms in 11.1.x
Priority: Normal » Major
Status: Active » Needs review

The cache metadata is incorrect on forms. Prior to #2578855: Form tokens are now rendered lazily, allow forms to opt in to be cacheable this did not matter as forms were not cached - but now they can be.

This MR also fixes the pipeline so it is green.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes

marcoscano made their first commit to this issue’s fork.

  • marcoscano committed f07d557f on 8.x-2.x authored by alexpott 
    Issue #3499592 by alexpott: Ensure caching metadata is correct on forms...
marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Status: Needs review » Fixed

Thank you for filing and fixing it! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.