Usage count does not match the number of entities

Thank you, for reporting the issue and creating the patch. Here are some suggestions.

1. +++ b/src/Controller/ListUsageController.php
   @@ -203,10 +203,15 @@ class ListUsageController extends ControllerBase {
   -        // If the label is empty it means this usage shouldn't be shown
   -        // on the UI, just skip this row.
   ...
   +          // If it is skipped on the UI, it could cause confusion to the user.
   +          // Instead, keep the entry on the UI without a link.
   

   Let's keep the above block, rephrase it and remove the latter one:

   If the label is empty then show the placeholder.

2. +++ b/src/Controller/ListUsageController.php
   @@ -203,10 +203,15 @@ class ListUsageController extends ControllerBase {
   +          //  If the label is empty,  the source entity either does not exist anymore
   +          // or the current entity is not linked to the entity it claims as the parent.
   

   Extra space after slashes and double space after , also comments can't be longer then 80 chars.

3. +++ b/src/Controller/ListUsageController.php
   @@ -203,10 +203,15 @@ class ListUsageController extends ControllerBase {
   +          // or the current entity is not linked to the entity it claims as the parent.
   

   Again the comment is > 80 chars.

4. +++ b/src/Controller/ListUsageController.php
   @@ -203,10 +203,15 @@ class ListUsageController extends ControllerBase {
   +          $parent_id = $source_entity->get('parent_id')->value;
   

   parent_id only exist for paragraph entity types so we need to check the entity type first. if ($source_entity->getEntityTypeId() == 'paragraph') {. We also need to check sset($this->get('parent_id')->value)

5. +++ b/src/Controller/ListUsageController.php
   @@ -203,10 +203,15 @@ class ListUsageController extends ControllerBase {
   +          $link ='Deleted  / Unlinked Node #'.$parent_id;
   

   A space missing after = sign and spaces are missing on both sides of . as well.

6. +++ b/src/Controller/ListUsageController.php
   @@ -203,10 +203,15 @@ class ListUsageController extends ControllerBase {
   +          //  If the label is empty,  the source entity either does not exist anymore
   

   This is also not true. We have

           $source_entity = $type_storage->load($source_id);
           if (!$source_entity) {
             // If for some reason this record is broken, just skip it.
             continue;
           }

   before this.

7. +++ b/src/Controller/ListUsageController.php
   @@ -203,10 +203,15 @@ class ListUsageController extends ControllerBase {
            $link = $this->getSourceEntityLink($source_entity);
   

   What if I change the logic in this function. There is

         if ($orphan) {
           return FALSE;
         }

   which we can update.

Let's address the failing test.

Thanks for your contribution!

I'd like to better understand your use case, when you mention in the issue summary:

The usage count is taking into account (...)

which count are you referring to? A value displayed in views? A value returned from an API call, such as \Drupal\entity_usage\EntityUsage::listSources() ?

Getting this page right is tricky, and there are several scenarios where we might want to skip rows. Non-deleted paragraphs, for instance, are the main example, but there are others as well. The code for this controller unfortunately is becoming more and more hacky-ish over time, has demonstrated to be the root of many issues and is in fact probably the main reason that triggered the whole module refactor idea in #3060802: Refactor module architecture in a simpler, opinionated and more performant approach. Would the new approach make more or less sense for your particular use case?

Thanks!

I have updated IS as per #8.

@rishvi and @marcoscano I think we can roll this patch on top of #3060802: Refactor module architecture in a simpler, opinionated and more performant approach.

Better title.

This patch no longer applies to the latest beta, I tracked it down to the changes in #3056026: Remove orphan handling of paragraphs when parent exists

After reading that issue, I think we can close this one as outdated or won't fix as the paragraph orphan issue has been tidied up considerably.

I agree, the paragraphs workaround was probably the source of most mismatches people could find. Closing this for now, please feel free to re-open if you experience this again with the latest release.

Thanks everyone!