Feedbacks after code review

Hello,

Thanks a lot for the module. I placed myself on the code from https://git.drupalcode.org/project/entity_share_websub/-/merge_requests/3 to test.

Here are some feedbacks. I don't know if they are already known and planned to be addressed.

-------

In modules/entity_share_websub_subscriber/config/schema/entity_share_websub_subscriber.schema.yml

cancel_description can be replaced by "type: text_format" directly.

cancel_title, cancel_text and confirm_text, label instead of string to be translatable.

------

In modules/entity_share_websub_subscriber/config/install/entity_share_websub_subscriber.settings.yml

I do not understand the reference to taxonomy term, I think this is project specific.

------

modules/entity_share_websub_hub/phpunit.xml: project related file to clean up.

------

I have no entry in entity_share_subscription_record on the client website. Maybe I misused the modules.

------

Successfully updaetd the channel IDs for subscriptions: typo

------

In contrib/entity_share_websub/modules/entity_share_websub_hub/entity_share_websub_hub.permissions.yml:

'see content subscriptions':

I don't know if putting quotes around permission machine name is recommended.

------

I guess this may be a big refactoring, but why not creating a dedicated content entity for entity_share_websub_hub_subscription?
It will avoid to have to provide a view and View's integration.

Impossible to test the view due to a fatal error:Fatal error: Trait 'Drupal\Console\Command\Shared\TranslationTrait' not found in /project/app/modules/custom/entity_share_websub/modules/entity_share_websub_hub/src/Plugin/views/field/SyndicationStatusField.php on line 19

---------

In modules/entity_share_websub_hub/src/SubscriptionInterface.php:

function getSubscribersBySids($sids);

Miss "public" keyword.

-------

BatchBuilder: Thanks! I didn't know this class existed!

------

process initial entity import asynchroniusly.: typo

------

modules/entity_share_websub_subscriber/src/SignatureTrait.php

to move into entity_share_websub directly to avoid duplicated code between hub and subscriber module.