Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.| Comment | File | Size | Author |
|---|---|---|---|
| #8 | entity_share-tests_cli-3084249-8.patch | 20.24 KB | grimreaper |
| #7 | entity_share-tests_cli-3084249-7.patch | 12.67 KB | grimreaper |
Comments
Comment #2
grimreaperChecking search_api and config_split which both modules have CLI commands and automated tests for that.
It seems that only methods without the io and t callables are testable.
So the CLI service will require some rework to have methods expecting $io and $t and other methods which makes the real process and where those last methods do not require $io and $t and return results to be parsed to display the correct messages.
It can be done if we only had error message and a final success message, but we have intermediate message when handling pagination.
So keeping this issue opened to get feedbacks. Depending on the feedbacks and the priorities the tests will be implemented.
Comment #3
grimreaperComment #4
sandboxplChecking following service https://git.drupalcode.org/project/entity_share/blob/8.x-2.x/modules/ent...
small progress messages returned in while loops , like this one:
https://git.drupalcode.org/project/entity_share/blob/8.x-2.x/modules/ent...
Aren't really neccessary, those are only informational, but removing them shouldn't provide any problems
Comment #5
grimreaperThanks @sandboxpl for the feedback.
Comment #6
grimreaperComment #7
grimreaperLet's test refactoring.
I found that the update option is broken.
I will add tests now.
Comment #8
grimreaperThis time previous patch + the actual tests.
Comment #10
grimreaper