The UI for finding and pulling content could be substantially improved by making a column for "Last Modified" that is has a click-sortable column. If it's possible, making _every_ column click-sortable would be helpful. But sorting on date, reverse-chronological seems like it's would be the most important sort to have available.
This meshes nicely with #2891653: Pull Form: better language selection UI, where it's being suggested that the "Language" column be removed.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | entity_share-sort_column-3077808-7.patch | 20.48 KB | grimreaper |
| #5 | entity_share-sort_column-3077808-5.patch | 16.2 KB | grimreaper |
| #4 | entity_share-sort_column-3077808-4.patch | 3.53 KB | grimreaper |
Comments
Comment #2
grimreaperCurrently, as the table is per channel and a channel is for one entity type / bundle / language combination. I think we can add the "changed" column (remote changed value) and having the title/label and changed columns sortable.
Comment #3
grimreaperComment #4
grimreaperWIP patch that add the changed column. Need to make it sortable.
Comment #5
grimreaperHere is a patch that adds sort on columns.
I will keep the two separated commits. One that add the changed column and the one that add the sort feature.
Comment #6
grimreaperBack to needs work to add a reset sort button. Also adding a test in entity_share_server about the new data in entity_share endpoint.
Comment #7
grimreaperTest added and a reset button too.
Comment #9
grimreaperComment #10
quicksketchThis is working great! Though I find it strange that there is no default sort at all. Shouldn't it sort by Modified Date (reverse chronological) by default? That would make it match the out-of-box listings for listing nodes, comments, and files.
It's not clear what order "resetting" puts content in. Seems like it's sort of the same as Modified Date with newest content at the bottom? IMO resetting the order should never be necessary, users would always want to sort by one of the available columns (though right now that's only date). None of the other listings in Drupal 8 have a reset button.
Comment #11
grimreaperThanks @quicksketch for the feedback.
There is no default sort on the columns because there can be one ore more sorts configured into the channel on the server website.
And so resetting the sort means going back to the sorts on the channel if existing.
Because when clicking on a column to sort it, at this moment it removes any sort existing from the channel.
Is it ok for you now?
Should some wording be changed or an helping text be added?
Comment #12
quicksketchOh! I didn't realize there even were sorts on the channel. I had not yet added any so the default listing was just "unordered" however JSON API (or MySQL) was returning them. That makes sense. In our case we will actually sort by "changed" date initially, so while the reset button will be redundant for us, it might not be for all sites.
Closing this back up. :)
Comment #13
grimreaperNo problem :)
Thanks for the feedback.