Hi, first of all thank you for this promising module.

Let's say I have a translatable content entity 'Email' and one of the fields in it is ‘field_header’., if this field aliased to be ‘header’ via the jsonapi_extras module, when try to sync a email entity I got a PHP error InvalidArgumentException: Field header is unknown. in Drupal\Core\Entity\ContentEntityBase->getTranslatedField(), it sounds like the module tries to find the field by the public name instead of the internal field name.

Going to attach a patch to look for the internal filed name

CommentFileSizeAuthor
#3 entity_share-use-internal-fieldname-2973972-3.patch1.66 KBmgalalm

Comments

mgalalm created an issue. See original summary.

mgalalm’s picture

mgalalm commented
Issue summary: View changes
mgalalm’s picture

mgalalm commented
Issue summary: View changes
Parent issue: #2946546: CLI integration - pull only new/changed entities »
StatusFileSize
new entity_share-use-internal-fieldname-2973972-3.patch1.66 KB
mgalalm’s picture

mgalalm commented
Status: Needs work » Needs review
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
Issue tags: +DevDaysLisbon, +DevDaysLisboa

Hi mgalalm,

Thanks for your patch.

I had to wait to be at DrupalDevDays to have at least time to say thank you.

I will try to review your patch during the event.

  • mgalalm authored b5899f2 on 8.x-1.x 
    Issue #2973972 by mgalalm, Grimreaper: Integration with jsonapi_extras.
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs review » Fixed

Hi mgalalm,

Thanks for your patch. I have been able to reproduce the bug and your patch fixes it.

It is now merged and pushed.

I also add a note in #2909022: Write tests to not forget to write a test about that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.