Problem/Motivation

Module should use Drupal Gitlab CI template with basic setup for code quality and tests.

Steps to reproduce

None.

Proposed resolution

Add Drupal Gitlab CI template.

Remaining tasks

  • Critical: Only compatible with drupal/diff 2.0.0-beta5 which is marked as not secure
  • Minor: cspell CI job not green yet, but it is not critical

User interface changes

To be compatible with drupal/diff 2.0.0 or higher form handling was refactored. So during testing it should be really properly be tested with stuff like block_content, group (only 2.x is supported yet!), media and taxonomy term entity diff forms.

API changes

None

Data model changes

None

Issue fork entity_revision_diff-3567088

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

voleger created an issue. See original summary.

voleger opened merge request !1

it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Status: Active » Needs work

A proper composer.json should be added to this module with require of drupal/diff contrib module.

This will fix failing PHP unit tests and also resolve some or maybe all errors mentioned in PHPStan CI job.

it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Title: Enable CI » Add Drupal Gitlab CI template
Issue summary: View changes
it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Status: Needs work » Needs review
it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Issue summary: View changes
it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Priority: Normal » Major

Priority raised to major to provide support for drupal/diff 2.0.0 or higher.

it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Related issues: +#3631120: Module is broken with drupal/diff 2.0.0 or higher