Problem/Motivation
After creating a CSV export, the CSV file gets downloaded by the browser automatically.
The user also receives the "Export successful. The download should automatically start shortly. If it doesn't, click Download." status message.
However, the download link in the status message doesn't work.
Steps to reproduce
- Create a CSV export
- Click on the download link in the status message
Proposed resolution
Fix the bug.
Remaining tasks
Fix the bug.
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | AfterMR-7.png | 122.38 KB | kanchan bhogade |
| #6 | BeforeMR-7.png | 4.71 MB | kanchan bhogade |
| #5 | entity_export-after.png | 93.2 KB | shruu_rao |
| #5 | entity_export-before.PNG | 19.77 KB | shruu_rao |
| #3 | download_link_fix-3447189-3.patch | 919 bytes | dpacassi |
Issue fork entity_export_csv-3447189
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
dpacassiPull request created, see:
https://git.drupalcode.org/project/entity_export_csv/-/merge_requests/7
Attaching a static patch file in case the PR gets rerolled.
Comment #4
dpacassiComment #5
shruu_rao commentedHi, Applied #3 patch. The patch applies successfully and resolves the issue.
Attaching screenshots for reference.
Comment #6
kanchan bhogade commentedHi
I've tested MR !7 on Drupal 10
MR is applied cleanly and Resolved the download link issue.
RTBC+1
Adding SS for reference
Moving to RTBC
Comment #7
kanchan bhogade commentedComment #8
kanchan bhogade commentedComment #9
flocondetoile> However, the download link in the status message doesn't work.
I guess that if the download link doesn't work, it's because the file has been already downloaded (and this is what your patch shows as "fix"). And as we delete the file once it has been downloaded, then the link is not relevant anymore. It's not really a bug, it's a feature ! So I think then, if the file is automaticcaly downloaded (or even manually), then the link/sentence about the download should be replaced by a sentence as "the file has been downloaded. Check your download directory.".
I think we must keep the feature which delete the file once downloaded, as we don't need to keep it anymore on the server.