Problem/Motivation

After creating a CSV export, the CSV file gets downloaded by the browser automatically.
The user also receives the "Export successful. The download should automatically start shortly. If it doesn't, click Download." status message.

However, the download link in the status message doesn't work.

Steps to reproduce

  • Create a CSV export
  • Click on the download link in the status message

Proposed resolution

Fix the bug.

Remaining tasks

Fix the bug.

User interface changes

None.

API changes

None.

Data model changes

None.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dpacassi created an issue. See original summary.

dpacassi’s picture

StatusFileSize
new919 bytes

Pull request created, see:
https://git.drupalcode.org/project/entity_export_csv/-/merge_requests/7

Attaching a static patch file in case the PR gets rerolled.

dpacassi’s picture

Status: Active » Needs review
shruu_rao’s picture

StatusFileSize
new19.77 KB
new93.2 KB

Hi, Applied #3 patch. The patch applies successfully and resolves the issue.
Attaching screenshots for reference.

kanchan bhogade’s picture

StatusFileSize
new4.71 MB
new122.38 KB

Hi
I've tested MR !7 on Drupal 10
MR is applied cleanly and Resolved the download link issue.

RTBC+1
Adding SS for reference

Moving to RTBC

kanchan bhogade’s picture

Status: Needs review » Reviewed & tested by the community
kanchan bhogade’s picture

flocondetoile’s picture

Status: Reviewed & tested by the community » Needs work

> However, the download link in the status message doesn't work.

I guess that if the download link doesn't work, it's because the file has been already downloaded (and this is what your patch shows as "fix"). And as we delete the file once it has been downloaded, then the link is not relevant anymore. It's not really a bug, it's a feature ! So I think then, if the file is automaticcaly downloaded (or even manually), then the link/sentence about the download should be replaced by a sentence as "the file has been downloaded. Check your download directory.".

I think we must keep the feature which delete the file once downloaded, as we don't need to keep it anymore on the server.