Warning during static code analysis using phan:

Call with 3 arg(s) to \entity_property_verbatim_set(&$data, $name, $value, $langcode, $type, $info) which requires 6 arg(s)

CommentFileSizeAuthor
#2 entity-static_code_analysis_3270904_2.patch961 bytesNatallia Kazarynava

Comments

Natallia Kazarynava created an issue. See original summary.

Natallia Kazarynava’s picture

Natallia Kazarynava commented
StatusFileSize
new entity-static_code_analysis_3270904_2.patch961 bytes
Natallia’s picture

Natallia commented
Status: Active » Needs review
tr’s picture

tr commented
Status: Needs review » Closed (won't fix)

Your patch changes an obsolete function with dead code that's unused by the Entity API - see the comment:

Do not make use of this function, instead use the new one.

That function should not be used anywhere. Back in D7 we did not have a mechanism in Drupal to deprecate functions like this. And even then, removing the function (i.e. changing the API of the Entity API module) would require a version number change.

So, I don't think this is something we should do now - the proper fix would be to remove that obsolete function but we can't do that without changing the version of the code. The error will not be triggered at runtime unless someone actually uses that obsolete function with PHP 8, and if that happens I think it is GOOD that they see an error because they really need to remove their use of that obsolete function - this will ensure they fix their problem.