Follow up to #3206793: Remove required parameter following optional parameter (PHP 8.0), which did the same thing for most of the Entity API.

Problem is, it turns out that entity.features.inc is not being used by the test cases at all, so the PHP 8.0 issues in entity.features.inc were never discovered by the Entity API tests.

Patch to follow ...

CommentFileSizeAuthor
#4 3222090-4-required-parameters-after-optional-parameters.patch1.92 KBtr
#2 3222090-2-required-parameters-after-optional-parameters.patch1.25 KBtr

Comments

TR created an issue. See original summary.

tr’s picture

tr commented
Status: Active » Needs review
StatusFileSize
new 3222090-2-required-parameters-after-optional-parameters.patch1.25 KB
jonathan1055’s picture

jonathan1055 commented

I've manually started a test at PHP 8 to see what happens now that you have fixed the missing tests.

tr’s picture

tr commented
StatusFileSize
new 3222090-4-required-parameters-after-optional-parameters.patch1.92 KB

Needs the composer.json from #3222097: EntityAPIRulesIntegrationTestCase fails with PHP 8.0 in order to use the -dev version of Rules where PHP 8.0 fixes have been made.

Here's a new patch.

tr’s picture

tr commented

To summarize:

The patch in #2 fixes the problems with entity.features.inc and allows Entity API to work with PHP 8.0 provided that Rules 7.x-2.x-dev is used. The patch in #4 just forces the testbot to use the -dev version of Rules.

What needs to be done now:

  • #2 needs to be committed.
  • Entity API needs a new release for PHP 8.0 compatibility.
  • Rules needs a new release for PHP 8.0 compatibility.

  • TR committed 64d6fd3 on 7.x-1.x 
    Issue #3222090 by TR: Remove required parameter following optional...
tr’s picture

tr commented
Status: Needs review » Fixed

Committed #2.

jonathan1055’s picture

jonathan1055 commented

Thanks, that's good.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.