Found a bunch of problems with the test suite on 8.7.x in #3065163: Require Drupal 8.7 and use EntityOwnerTrait and I guess we can fix some or all of them in 8.6.x already without bumping the dependency yet.

CommentFileSizeAuthor
#4 3065338-4.patch8.79 KBtstoeckler
#4 3065338-2-4-interdiff.txt3.26 KBtstoeckler
#2 3065338-2.patch12.05 KBtstoeckler

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review
StatusFileSize
new 3065338-2.patch12.05 KB

Here we go.

Status: Needs review » Needs work

The last submitted patch, 2: 3065338-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Needs review
StatusFileSize
new 3065338-2-4-interdiff.txt3.26 KB
new 3065338-4.patch8.79 KB

OK, so I guess the PhpUnit change is not compatible with 8.6 yet, will move that to #3065163: Require Drupal 8.7 and use EntityOwnerTrait for now.

  • bojanz committed 12f8c63 on 8.x-1.x authored by tstoeckler 
    Issue #3065338 by tstoeckler: Prepare for 8.7 deprecations/changes
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.